Skip to content

libzmq: fix build #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2024
Merged

libzmq: fix build #2842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pythonforandroid/recipes/libzmq/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@


class LibZMQRecipe(Recipe):
version = '4.3.2'
version = '4.3.4'
url = 'https://github.com/zeromq/libzmq/releases/download/v{version}/zeromq-{version}.zip'
depends = []
built_libraries = {'libzmq.so': 'src/.libs'}
Expand Down Expand Up @@ -34,6 +34,7 @@ def build_arch(self, arch):
'--prefix={}'.format(prefix),
'--with-libsodium=no',
'--disable-libunwind',
'--disable-Werror',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @T-Dynamos !

Why --disable-Werror is needed? Do you have a trace or something else?

Copy link
Contributor Author

@T-Dynamos T-Dynamos Jun 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of #2811 (comment) (also termux uses it see https://github.com/termux/termux-packages/blob/2775fb84d3c9a65df92908d2a94fd41977c31538/packages/libzmq/build.sh#L13)

_env=env)
shprint(sh.make, _env=env)
shprint(sh.make, 'install', _env=env)
Expand Down