Skip to content

Use platform.uname instead of os.uname #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Use platform.uname instead of os.uname #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ to install and begin creating APKs and AABs.

(for the develop branch: `pip install git+https://github.com/kivy/python-for-android.git`)

Test that the install works with:
Test that theinstall works with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch!
For some reason I've read: "Test that install works with:" 🫣

@Julian-O can you take care of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just spent some time trying to figure out how I managed to break this comment.

  1. Fix a legitimate typo in a comment of no consequence.
  2. Accidentally delete a space in another file.
  3. A few days later, at commit time, see that delta for the lost space, but don't notice it is the wrong way. Think "Ah, yeah, the typo I fixed. I will include that in this PR."

Sorry. PR with both inconsequential fixes coming very soon.


p4a --version

Expand Down
5 changes: 3 additions & 2 deletions pythonforandroid/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import contextlib
from os.path import exists, join
from os import getcwd, chdir, makedirs, walk, uname
from os import getcwd, chdir, makedirs, walk
from platform import uname
import shutil
from fnmatch import fnmatch
from tempfile import mkdtemp
from pythonforandroid.logger import (logger, Err_Fore, error, info)


build_platform = '{system}-{machine}'.format(
system=uname()[0], machine=uname()[-1]).lower()
system=uname().system, machine=uname().machine.lower())
"""the build platform in the format `system-machine`. We use
this string to define the right build system when compiling some recipes or
to get the right path for clang compiler"""
Expand Down