Skip to content

add custom recipe support [needs py3 testing] #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2015

Conversation

kived
Copy link
Contributor

@kived kived commented Dec 14, 2015

Adds two additional locations to find recipes.

First, a local recipes folder is checked. This defaults to ./p4a-recipes, and can be set via the command line option --local-recipes/--local_recipes.

Next, a user-local folder is checked in the user-local storage (i.e. ~/.local/share/python-for-android/recipes).

Finally, the standard p4a recipes will be checked.

Note that while this works on py2, it will need to be tested on 3.3/3.4 AND 3.5. 3.5 will use the newer spec_from_file_location and module_from_spec methods in importlib.util, while 3.3/3.4 will use the older (deprecated?) SourceFileLoader. py2 just uses the simple imp.load_source.

inclement added a commit that referenced this pull request Dec 19, 2015
add custom recipe support [needs py3 testing]
@inclement inclement merged commit 75c71d6 into kivy:master Dec 19, 2015
@inclement
Copy link
Member

I didn't actually test on python3, but since it seems python2 should work fine I guess let's not dawdle and fix it if it turns out wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants