Skip to content

Added sqlite3 recipe #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Added sqlite3 recipe #664

wants to merge 4 commits into from

Conversation

brussee
Copy link
Contributor

@brussee brussee commented Mar 2, 2016

No description provided.

@brussee brussee mentioned this pull request Mar 3, 2016
@inclement
Copy link
Member

Have you tested this (maybe on its own, not via python)? In the old toolchain, the python recipe also needs some additions to build with sqlite3.

@brussee
Copy link
Contributor Author

brussee commented Mar 4, 2016

Tested with Apsw script: https://github.com/rogerbinns/apsw/blob/master/example-code.py

03-05 00:34:07.945: I/python(28084): SQLite memory usage current 379816 max 447632

@kived
Copy link
Contributor

kived commented Mar 4, 2016

Because that's a sqlite wrapper. What @inclement is referring to is the builtin sqlite3 module, which will not be built if Python itself doesn't know about sqlite.

@kived
Copy link
Contributor

kived commented Mar 4, 2016

Just like pyopenssl will work if you have openssl, but Python standard libs like urllib won't have SSL support unless Python was also compiled against openssl.

@brussee
Copy link
Contributor Author

brussee commented Mar 5, 2016

It does not work without Apsw at the moment. See #672

@brussee brussee force-pushed the sqlite3-recipe branch 2 times, most recently from 95f2849 to de19154 Compare March 27, 2016 18:15
@brussee
Copy link
Contributor Author

brussee commented Apr 14, 2016

Builtin sqlite3 module now works in #672 !

@inclement
Copy link
Member

Checking the commits, am I right in understanding that this PR can be closed, while #665 and #672 should be merged (and include all the content from this one)?

@brussee
Copy link
Contributor Author

brussee commented May 8, 2016

That's right.

@brussee brussee closed this May 8, 2016
@brussee brussee deleted the sqlite3-recipe branch May 9, 2016 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants