Skip to content

Fixed error messages when build vars aren't set #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2016
Merged

Fixed error messages when build vars aren't set #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pythonforandroid/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def android_api(self, value):
def ndk_ver(self):
'''The version of the NDK being used for compilation.'''
if self._ndk_ver is None:
raise ValueError('Tried to access android_api but it has not '
raise ValueError('Tried to access ndk_ver but it has not '
'been set - this should not happen, something '
'went wrong!')
return self._ndk_ver
Expand All @@ -134,7 +134,7 @@ def ndk_ver(self, value):
def sdk_dir(self):
'''The path to the Android SDK.'''
if self._sdk_dir is None:
raise ValueError('Tried to access android_api but it has not '
raise ValueError('Tried to access sdk_dir but it has not '
'been set - this should not happen, something '
'went wrong!')
return self._sdk_dir
Expand All @@ -147,7 +147,7 @@ def sdk_dir(self, value):
def ndk_dir(self):
'''The path to the Android NDK.'''
if self._ndk_dir is None:
raise ValueError('Tried to access android_api but it has not '
raise ValueError('Tried to access ndk_dir but it has not '
'been set - this should not happen, something '
'went wrong!')
return self._ndk_dir
Expand Down Expand Up @@ -314,6 +314,7 @@ def prepare_build_environment(self, user_sdk_dir, user_ndk_dir,
'need to manually set the NDK ver.')
if ndk_ver is None:
warning('Android NDK version could not be found, exiting.')
exit(1)
self.ndk_ver = ndk_ver

info('Using {} NDK {}'.format(self.ndk.capitalize(), self.ndk_ver))
Expand Down