-
Notifications
You must be signed in to change notification settings - Fork 551
maintenance: added types to KubeConfig#loadFromOptions
input
#1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @emeraldsanto! |
KubeConfig#loadFromOptions
inputKubeConfig#loadFromOptions
input
Thanks for the PR, this looks fine but CI/CD is failing b/c of the stricter types. I think we need to make some fields in the existing types optional (e.g. |
@brendandburns good catch! I've gone ahead with the change and confirmed the tests pass locally. However that type has not been changed in 5 years so I'm worried that marking this field as optional now might be a breaking change? |
I looked at the code and I think we'll be ok. Most people are probably not including it anyway... |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, emeraldsanto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(and fwiw, adding stronger types is probably a breaking change anyway :) ) |
Summary
This PR adds stronger types to the
KubeConfig#loadFromOptions
method which is currently acceptingany
, even though all the necessary types are already defined and available to use.