Skip to content

fix: remove final refrences to request + fix tests #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ '16', '14', '12' ]
node: [ '18', '16', '14', '12' ]
name: Node ${{ matrix.node }} validation
steps:
- uses: actions/checkout@v2
Expand Down
12 changes: 6 additions & 6 deletions FETCH_MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ Code will be on the `master` branch.
- [x] Match src/gen/api.ts to new generated layout (it changes slightly)
- [ ] Fix errors in /src folder (due to new api)
- [x] migrate src/auth.ts, the dependent implementations (ex: azure_auth, gcp_auth etc) and tests to fetch api from request
- [ ] migrate src/log.ts and its tests to fetch api from request
- major remaining work is fixing up async signatures and return piping
- [ ] migrate src/watch.ts and its tests to fetch api from request
- remove decprecated requestImpl and RequestInterface
- implement queryParams parameter in watch method by injecting them into the fetch call
- update tests in src/watch_test.ts
- [x] migrate src/log.ts and its tests to fetch api from request
- [x] major remaining work is fixing up async signatures and return piping
- [x] migrate src/watch.ts and its tests to fetch api from request
- [x] remove decprecated requestImpl and RequestInterface
- [x] implement queryParams parameter in watch method by injecting them into the fetch call
- [x] update tests in src/watch_test.ts
- [ ] Fix errors in test (due to new api)
- [ ] Test all features
- [ ] Fix examples and validate their param signatures (due to new api)
Expand Down
Loading