-
Notifications
You must be signed in to change notification settings - Fork 552
Regenerate with new openapi generator #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate with new openapi generator #850
Conversation
/cc @davidgamero |
@uesyn: GitHub didn't allow me to request PR reviews from the following users: davidgamero. Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @davidgamero looks like a number of the paths changed here? (e.g. the |
Also, we really aren't running any unit tests on this branch so we need to be extra careful. |
hello @uesyn, nice to see you again! |
let me take a shot at getting a couple more unit tests running this weekend so we can verify we can retain progress. |
@brendandburns
When import mapping feature is added to openapi-generator, the template of generated codes was changed to simplify openapi-generator implementation. ref: OpenAPITools/openapi-generator#12957 (comment) The reason why that the lines related to IntOrString and V1MicroTime is changed is the result of generating with import mapping feature. (main purpose of this PR) The other lines changed is the result that |
i tried running the tests on your branch and it looks like you forked at #44f5170046d7cecd0738935942ce2d92f7422690 which is a couple commits behind the current state of the release-1.x branch. Could you merge the release-1.x branch into yours or regenerate on top of the current head so I can give it a try? |
69d73ae
to
cf0714c
Compare
@davidgamero |
yep i can confirm that the unit tests run and the progress is retained |
@davidgamero: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm Thanks! (apologies for the delay, I was on vacation) |
/approve (instead of /appprove :P) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, uesyn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is for release-1.x branch.
openapi-generator supported import-mapping for typescript client generator.
ref: OpenAPITools/openapi-generator#12957
With it, we don't need to do workaround like copying IntOrString type to IntOrString.ts.
In this PR, re-generate codes using openapi generator which supports import-mapping.
In addition, cherry-pick #830.