Move watch callback out of try-catch

[Nicklason]

Issue: #856

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Nicklason / name: Nicklas (a9d16b3)

[k8s-ci-robot]

Welcome @Nicklason!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Thanks for the PR! Code looks good.

Can you add a unit test to cover this behavior? You should be able to adapt the code from here: https://github.com/kubernetes-client/javascript/blob/master/src/watch_test.ts#L320 but remove the parse error and set your watch handler to throw.

[Nicklason]

@brendandburns I have added the test. It tests if the handler receives the correct values and if the promise fails because of the handler error without calling the done callback.

[brendandburns]

/lgtm
/approve

Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Nicklason

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment