Skip to content

bump openapigen commit and mocha to get native javascript url wrappers #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

bump openapigen commit and mocha to get native javascript url wrappers #964

wants to merge 12 commits into from

Conversation

davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Jan 20, 2023 •
edited
Loading

get our URL parsing to use the native URL instead of a deprecated dependency we inherited from OpenAPIGen
OpenAPITools/openapi-generator#14319

also remove the last of our shims 'models/IntOrString' residual file that isn't needed since the import mapping works now!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 20, 2023
@davidgamero
Copy link
Contributor Author

looks like theres'a tslint v prettier issue atm, i'm investigating

@brendandburns
Copy link
Contributor

@davidgamero this change lgtm once you sort out the linting.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2023
@davidgamero davidgamero changed the title bump openapigen commit to get native javascript url wrappers bump openapigen commit and mocha to get native javascript url wrappers Jan 23, 2023
@davidgamero
Copy link
Contributor Author

ended up having to make the mocha jump from v5 to v10 to get the critical CVEs out, but it was just some config changes and some small interface tightening :)

@davidgamero
Copy link
Contributor Author

ah yes, codeql thinks i both fixes and reintroduced the same certificate validation vuln in config_test.ts

@davidgamero
Copy link
Contributor Author

@brendandburns idk how to exclude the test file/mark that this isn't a new issue for CodeQL, but we are good to merge now- linting and testing is all passing

davidgamero
davidgamero commented Feb 16, 2023
View reviewed changes
src/config_test.ts Outdated
@@ -265,24 +265,24 @@ describe('KubeConfig', () => {
const rc = new RequestContext(testServerName1, HttpMethod.GET);
await kc.applySecurityAuthentication(rc);
await kc.applytoHTTPSOptions(opts);
const expectedCA = Buffer.from('CADATA2', 'utf-8')
const expectedCA = Buffer.from('CADATA2', 'utf-8');
const expectedAgent = new https.Agent({
ca: expectedCA,
cert: undefined,
key: undefined,
passphrase: undefined,
pfx: undefined,
rejectUnauthorized: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't an actual new vulnerability, codeql is triggering on a test that simulates password auth which has rejectUnauthorized: false

@davidgamero
Copy link
Contributor Author

i believe this is good to go now @brendandburns

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidgamero
Once this PR has been reviewed and has the lgtm label, please assign drubin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2023
@davidgamero davidgamero mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@drubin drubin Awaiting requested review from drubin

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgamero @brendandburns @k8s-ci-robot