Set GOPROXY to default if it is not configured

[joonas]

What this PR does / why we need it:

This is necessary since go env GOPROXY will return an empty string if the value is not set, thus setting GOPROXY to an empty string, which doesn't quite do what we want.

Special notes for your reviewer:

I've verified this locally by doing a fresh checkout without GOPROXY being set and running make test, which resulted in:

verifying gomodules.xyz/jsonpatch/[email protected]: checksum mismatch
	downloaded: h1:OyHbl+7IOECpPKfVK42oFr6N7+Y2dR+Jsb/IiDV3hOo=
	go.sum:     h1:lHNQverf0+Gm1TbSbVIDWVXOhZ2FpZopxRqpr2uIjs4=
make: *** [fmt] Error 1

After applying this change and running make test again things worked as expected.

Release note:

NONE

/cc @chuckha @amy

[k8s-ci-robot]

Welcome @joonas!

It looks like this is your first PR to kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @joonas. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/ok-to-test
/lgtm

[ncdc]

/hold
we want to honor go env GOPROXY if we can

[ncdc]

I have a clean checkout, I don't have GOPROXY set, and make test passes for me...

[joonas]

I have a clean checkout, I don't have GOPROXY set, and make test passes for me...

@ncdc Just to check, did you run go clean -modcache before running make test to make sure you have an empty cache?

[ncdc]

Doing that now. Will report back

[ncdc]

Ok I get the same error with a clean modcache

[joonas]

Ok I get the same error with a clean modcache

Sorry I should've mentioned that being a pre-requisite originally on the ticket.

The goal is to honor GOPROXY if it's set, but set a reasonable default in case it's not in order to get around the error with jsonpatch.

[ncdc]

How about this?

GOPROXY := $(shell go env GOPROXY)
ifeq ($(GOPROXY),)
GOPROXY := https://proxy.golang.org
endif

[joonas]

Happy to change it to that, that's definitely more succinct & idiomatic.

[ncdc]

LGTM, please squash & thanks!
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joonas, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncdc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chuckha]

/lgtm

thanks @joonas

[chuckha]

/hold cancel

[ncdc]

/lgtm