Add kubebuilder markers to CRDs for status and namespace #117
Conversation
Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
|
/assign @chuckha @fabriziopandini |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -49,6 +49,9 @@ type KubeadmConfigStatus struct { | |||
| } | |||
|
|
|||
| // +kubebuilder:object:root=true | |||
| // +kubebuilder:resource:path=kubeadmconfigs,scope=Namespaced | |||
| // +kubebuilder:storageversion | |||
There was a problem hiding this comment.
do we have conversion enabled?
what does this do when conversion is not enabled?
There was a problem hiding this comment.
I think setting it proactively will help when we do enable conversions in the future
There was a problem hiding this comment.
The storageversion serves for conversion and for future version iterations. Other CAP* projects specify this field as well
| @@ -49,6 +49,9 @@ type KubeadmConfigStatus struct { | |||
| } | |||
|
|
|||
| // +kubebuilder:object:root=true | |||
| // +kubebuilder:resource:path=kubeadmconfigs,scope=Namespaced | |||
There was a problem hiding this comment.
namespaced is the default if I'm reading https://book.kubebuilder.io/reference/markers/crd.html correctly. I don't really know what this is doing otherwise. Why do we need it?
There was a problem hiding this comment.
It's actually not, it'll default to empty
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR adds kubebuilder directives to
KubeadmConfigto ensure:Statussubresource.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: