This repository was archived by the owner on Jul 30, 2021. It is now read-only.
Update control-plane label value as cabpk-controller-manager #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
detiber
reviewed
Aug 13, 2019
|
nice, this has bugged me in the past. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update
control-planelabel value ascabpk-controller-manager.controller-managercan't tell what kind of controller manager it is, I think.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
I found that the label
kube-controller-manageruses iscomponent=kube-controller-manager.We can also consider adding a
component=cabpk-controller-managerlabel.Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
/cc @chuckha @ncdc