This repository was archived by the owner on Jul 30, 2021. It is now read-only.
Bring back AdditionalUserDataFiles #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Goldstein <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XS
|
@amy this will fix the manifest verification failure in your PR |
detiber
reviewed
Aug 6, 2019
| @@ -33,6 +33,9 @@ type KubeadmConfigSpec struct { | |||
| // JoinConfiguration is the kubeadm configuration for the join command | |||
| // +optional | |||
| JoinConfiguration *kubeadmv1beta1.JoinConfiguration `json:"joinConfiguration,omitempty"` | |||
| // AdditionalUserDataFiles specifies extra files to be passed to user_data upon creation. | |||
| // +optional | |||
| AdditionalUserDataFiles []Files `json:"additionalUserDataFiles,omitempty"` | |||
There was a problem hiding this comment.
Does this need to be wired up anywhere in the cloudinit code?
There was a problem hiding this comment.
Yes but I'm going to file another issue for that.
|
/lgtm |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Goldstein [email protected]
What this PR does / why we need it:
Bring back what was accidentally removed in #42.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: