Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Implement the NestedAPIServer controller #37

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Implement the NestedAPIServer controller #37

merged 1 commit into from
Apr 6, 2021

Conversation

charleszheng44
Copy link
Contributor

This PR includes the implementation of the NestedAPIServer controller.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 25, 2021
@charleszheng44 charleszheng44 force-pushed the feature/nestedapiserver-controller branch from 2c16bd6 to ec1a1b6 Compare March 25, 2021 16:53
christopherhein
christopherhein reviewed Mar 30, 2021
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is coming together nicely, couple comments from my first pass. We probably need to do some tests still?

@charleszheng44 charleszheng44 force-pushed the feature/nestedapiserver-controller branch from ec1a1b6 to 83dfe0e Compare April 2, 2021 18:30
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2021
@charleszheng44 charleszheng44 force-pushed the feature/nestedapiserver-controller branch from 83dfe0e to 77a5965 Compare April 2, 2021 18:36
@christopherhein
Copy link
Contributor

Awesome updates, this looks great. I'm inclined to merge this. Does anyone else want to give it a scan? @Fei-Guo ?

@charleszheng44 charleszheng44 force-pushed the feature/nestedapiserver-controller branch from 77a5965 to ae7e2a7 Compare April 6, 2021 18:59
Fei-Guo
Fei-Guo approved these changes Apr 6, 2021
View reviewed changes
Copy link

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Fei-Guo,charleszheng44]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fei-Guo Fei-Guo merged commit a2cecf1 into kubernetes-retired:master Apr 6, 2021
@christopherhein christopherhein mentioned this pull request May 5, 2021
Closed
@charleszheng44 charleszheng44 mentioned this pull request Jun 3, 2021
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherhein christopherhein christopherhein left review comments

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@davidewatson davidewatson Awaiting requested review from davidewatson

@detiber detiber Awaiting requested review from detiber

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charleszheng44 @christopherhein @k8s-ci-robot @Fei-Guo