-
Notifications
You must be signed in to change notification settings - Fork 116
Cherry pick of #283, #286, #294 #290
Cherry pick of #283, #286, #294 #290
Conversation
Hi @keisukesakasai. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, @adrianludwin /assign @adrianludwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after one question about the go.mod changes
go.mod
Outdated
|
||
require github.com/spf13/afero v1.6.0 // indirect | ||
|
||
replace ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't really question this last time - why is this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The replace
clause, just to clarify)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @adrianludwin
In conclusion, the replace clause seems to be unnecessary.
It was added #283 as a workaround and has to be unneeded in #286.
(ref. kubernetes/kubernetes#79384)
Fundamentally this was my mistake... sorry.
So I removed it in #294 and please check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it, can you add #294 to this PR as well? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it, please check. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keisukesakasai Thanks your add:)
/ok-to-test @adrianludwin can approve when ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, keisukesakasai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #283 , #286 , #294 on master.
#283: Show HierarchicalResourceQuota status by kubectl-hns
#286 : Remove unneeded dependency to k8s.io/kubernetes
#294: Remove unneeded replace clause from go.mod
The discussion regarding the content can be found here:
#284 (comment)