Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Fix links and directories #3

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix links and directories #3

merged 1 commit into from
May 4, 2021

Conversation

rjbez17
Copy link
Contributor

@rjbez17 rjbez17 commented May 4, 2021

This PR should come after #2

I manually changed all links and directories to remove multi-tenancy, incubator/hnc, etc into the root directory in this repo. The only links I kept original were links to existing releases.

After running this I did:

make build
make kubectl
make kind-reboot
make test-smoke
make test-e2e

Here are e2e results running against kind:

Ran 22 of 34 Specs in 564.680 seconds
SUCCESS! -- 22 Passed | 0 Failed | 1 Pending | 11 Skipped
--- PASS: TestE2e (564.68s)
PASS
ok  	sigs.k8s.io/hierarchical-namespaces/test/e2e	564.804s

@rjbez17 rjbez17 requested review from adrianludwin and yiqigao217 May 4, 2021 02:48
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2021
@rjbez17
Copy link
Contributor Author

rjbez17 commented May 4, 2021

/assign @adrianludwin
/assign @yiqigao217
/hold

Hold for #2

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@adrianludwin
Copy link
Contributor

lmk when I should review this

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2021
@rjbez17
Copy link
Contributor Author

rjbez17 commented May 4, 2021

@adrianludwin ready for review

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
@rjbez17
Copy link
Contributor Author

rjbez17 commented May 4, 2021

@adrianludwin this I covered them all, ptal

Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Feel free to remove the hold if you want to handle the last two problems in a followup CL.

* [v0.9](https://github.com/kubernetes-sigs/multi-tenancy/milestone/21): move
* [v0.9](https://github.com/kubernetes-sigs/hierarchical-namespaces/milestone/21): move
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create these milestones in the new repo so we can have the correct number here? But you can also do that in a followup PR if you like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the milestones will be carried over when we use the tool to copy the issues. @yiqigao217 can you confirm? I'd prefer to use that than do them manually now and have it mess up the migration

@@ -7,6 +7,6 @@ This file contains links to all the HNC documents (sorted by last updated).
- [2019/12] [HNC CLI naming](http://bit.ly/hnc-cli-naming)
- [2020/01] [HNC self-service namespaces UX](http://bit.ly/hnc-self-serve-ux)
- [2020/01] [HNC type configuration](http://bit.ly/hnc-type-configuration)
- [2020/02] [Metrics user guide: Stackdriver on GKE](https://github.com/kubernetes-sigs/multi-tenancy/blob/master/incubator/hnc/doc/metrics/stackdriver-gke.md)
- [2020/02] [Metrics user guide: Stackdriver on GKE](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/doc/metrics/stackdriver-gke.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably just change this to metrics/stackdriver-gke.md since we're already in the docs/ directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is a 404 in the old repo as well, created #7 to investigate and fix the link.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 4, 2021
@adrianludwin
Copy link
Contributor

adrianludwin commented May 4, 2021 via email

@rjbez17
Copy link
Contributor Author

rjbez17 commented May 4, 2021

/hold cancel

issues filed to fix remaining things

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5f7c637 into master May 4, 2021
@adrianludwin adrianludwin deleted the maint/fix_dirs branch October 14, 2021 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants