-
Notifications
You must be signed in to change notification settings - Fork 115
Conversation
/assign @adrianludwin Hold for #2 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lmk when I should review this |
@adrianludwin ready for review /hold cancel |
@adrianludwin this I covered them all, ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Feel free to remove the hold if you want to handle the last two problems in a followup CL.
* [v0.9](https://github.com/kubernetes-sigs/multi-tenancy/milestone/21): move | ||
* [v0.9](https://github.com/kubernetes-sigs/hierarchical-namespaces/milestone/21): move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe create these milestones in the new repo so we can have the correct number here? But you can also do that in a followup PR if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the milestones will be carried over when we use the tool to copy the issues. @yiqigao217 can you confirm? I'd prefer to use that than do them manually now and have it mess up the migration
@@ -7,6 +7,6 @@ This file contains links to all the HNC documents (sorted by last updated). | |||
- [2019/12] [HNC CLI naming](http://bit.ly/hnc-cli-naming) | |||
- [2020/01] [HNC self-service namespaces UX](http://bit.ly/hnc-self-serve-ux) | |||
- [2020/01] [HNC type configuration](http://bit.ly/hnc-type-configuration) | |||
- [2020/02] [Metrics user guide: Stackdriver on GKE](https://github.com/kubernetes-sigs/multi-tenancy/blob/master/incubator/hnc/doc/metrics/stackdriver-gke.md) | |||
- [2020/02] [Metrics user guide: Stackdriver on GKE](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/doc/metrics/stackdriver-gke.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably just change this to metrics/stackdriver-gke.md
since we're already in the docs/
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is a 404 in the old repo as well, created #7 to investigate and fix the link.
sgtm
…On Tue, May 4, 2021 at 4:46 PM Ryan Bezdicek ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#3 (comment)>
:
> -* [v0.9](https://github.com/kubernetes-sigs/multi-tenancy/milestone/21): move
+* [v0.9](https://github.com/kubernetes-sigs/hierarchical-namespaces/milestone/21): move
I think the milestones will be carried over when we use the tool to copy
the issues. @yiqigao217 <https://github.com/yiqigao217> can you confirm?
I'd prefer to use that than do them manually now and have it mess up the
migration
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZA6G774VIUCTJEM2UTTMBMKHANCNFSM44B35XDA>
.
|
/hold cancel issues filed to fix remaining things |
This PR should come after #2
I manually changed all links and directories to remove multi-tenancy, incubator/hnc, etc into the root directory in this repo. The only links I kept original were links to existing releases.
After running this I did:
Here are e2e results running against kind: