Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Fix e2e tests #31

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

adrianludwin
Copy link
Contributor

The e2e tests refer to the old "incubator/hnc" directory which doesn't
exist in this repo.

Tested: as usual, I don't have any way to test Prow configs or flows.
However, this is in response to a Prow failure that clearly identifies
this line.

The e2e tests refer to the old "incubator/hnc" directory which doesn't
exist in this repo.

Tested: as usual, I don't have any way to test Prow configs or flows.
However, this is in response to a Prow failure that clearly identifies
this line.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from rjbez17 and srampal May 6, 2021 13:31
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2021
@adrianludwin
Copy link
Contributor Author

/assign @rjbez17
/assign @yiqigao217

This'll also be a good test to see whether pull-hnc-test succeeds :)

Copy link
Contributor

@yiqigao217 yiqigao217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1e0590b into kubernetes-retired:master May 6, 2021
@adrianludwin adrianludwin deleted the fix-e2e branch May 6, 2021 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants