Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Support unpropagated labels #321

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

timbyr
Copy link
Contributor

@timbyr timbyr commented Jul 21, 2023

By default ArgoCD use labels to understand which objects it controls.

When HNC propagates those resources ArgoCD assumes ownership of those
resources and attempts to reconcile it with current state, usually
leading to deletion of those resources.
This causes a feedback loop where ArgoCD requests a deletion of an
object, that is blocked by the HNC webhook, and HNC no longer is able to
properly manage the resource due to the deletion finaliser set on the
resource.

This is similar behaviour to ConfigSync with annotations.

This commit adds an unpropagated-labels command line argument following the
implementation of the unpropagated-annotations argument. This allows
cluster operators to disable propagation of labels owned by systems like
ArgoCD.

Tested:

  • Implemented additional e2e test matching unpropagated-annotations tests.
  • Manually validated that configured labels were not propogated as expected
    and ArgoCD did not adopt propgated resources.

By default ArgoCD use labels to understand which objects it controls.

When HNC propagates those resources ArgoCD assumes ownership of those
resources and attempts to reconcile it with current state, usually
leading to deletion of those resources.
This causes a feedback loop where ArgoCD requests a deletion of an
object, that is blocked by the HNC webhook, and HNC no longer is able to
properly manage the resource due to the deletion finaliser set on the
resource.

This is similar behaviour to ConfigSync with annotations.

This commit adds an unpropagated-labels command line argument following the
implementation of the unpropagated-annotations argument. This allows
cluster operators to disable propagation of labels owned by systems like
ArgoCD.

Tested:
* Implemented additional e2e test matching unpropagated-annotations tests.
* Manually validated that configured labels were not propogated as expected
  and ArgoCD did not adopt propgated resources.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @timbyr!

It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @timbyr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2023
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to leave this so long, but this is a great change, no notes! Thanks for the submission :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, timbyr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@adrianludwin adrianludwin added this to the release-v1.2 milestone Sep 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit d9eb636 into kubernetes-retired:master Sep 15, 2023
@timbyr timbyr deleted the unpropogatedlabels branch September 25, 2023 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants