Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Update docs for new repo #34

Merged
merged 1 commit into from
May 6, 2021

Conversation

adrianludwin
Copy link
Contributor

A variety of cleanups:

  • Move CONTRIBUTING.md to the /docs directory and actually add the
    useful information that was previously in the README.
  • Update the readme and user guide to explain the difference between the
    new and old repo.
  • Update the Krew documentation so that it doesn't need to be updated
    every release, and to point to the new repo.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2021
@adrianludwin
Copy link
Contributor Author

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from srampal and tashimi May 6, 2021 15:30
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
from the command line, [as documented
here](https://kubernetes.io/docs/reference/access-authn-authz/rbac/#referring-to-subjects).

I *think* you can also use client certificate requests but I haven't tried that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I -> We

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rjbez17
Copy link
Contributor

rjbez17 commented May 6, 2021

a few nits but lgtm if you decide to skip them (remove hold).

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adrianludwin,rjbez17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

A variety of cleanups:
* Move CONTRIBUTING.md to the /docs directory and actually add the
useful information that was previously in the README.
* Update the readme and user guide to explain the difference between the
new and old repo.
* Update the Krew documentation so that it doesn't need to be updated
every release, and to point to the new repo.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@adrianludwin
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2021
@rjbez17
Copy link
Contributor

rjbez17 commented May 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit adc2e87 into kubernetes-retired:master May 6, 2021
@adrianludwin adrianludwin deleted the releases branch March 24, 2022 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants