ignore target group health check timeout for NLB (#1727)

Author: kishorj

pkg/service/model_build_target_group.go

@@ -94,10 +94,6 @@ func (t *defaultModelBuildTask) buildTargetGroupHealthCheckConfig(ctx context.Co
 	if err != nil {
 		return nil, err
 	}
-	timeoutSeconds, err := t.buildTargetGroupHealthCheckTimeoutSeconds(ctx)
-	if err != nil {
-		return nil, err
-	}
 	healthyThresholdCount, err := t.buildTargetGroupHealthCheckHealthyThresholdCount(ctx)
 	if err != nil {
 		return nil, err
@@ -111,7 +107,6 @@ func (t *defaultModelBuildTask) buildTargetGroupHealthCheckConfig(ctx context.Co
 		Protocol:                &healthCheckProtocol,
 		Path:                    healthCheckPathPtr,
 		IntervalSeconds:         &intervalSeconds,
-		TimeoutSeconds:          &timeoutSeconds,
 		HealthyThresholdCount:   &healthyThresholdCount,
 		UnhealthyThresholdCount: &unhealthyThresholdCount,
 	}, nil

pkg/service/model_build_target_group_test.go

@@ -179,7 +179,6 @@ func Test_defaultModelBuilderTask_buildTargetHealthCheck(t *testing.T) {
 				Port:                    &trafficPort,
 				Protocol:                (*elbv2.Protocol)(aws.String(string(elbv2.ProtocolTCP))),
 				IntervalSeconds:         aws.Int64(10),
-				TimeoutSeconds:          aws.Int64(10),
 				HealthyThresholdCount:   aws.Int64(3),
 				UnhealthyThresholdCount: aws.Int64(3),
 			},
@@ -205,7 +204,6 @@ func Test_defaultModelBuilderTask_buildTargetHealthCheck(t *testing.T) {
 				Protocol:                (*elbv2.Protocol)(aws.String("HTTP")),
 				Path:                    aws.String("/healthz"),
 				IntervalSeconds:         aws.Int64(10),
-				TimeoutSeconds:          aws.Int64(30),
 				HealthyThresholdCount:   aws.Int64(2),
 				UnhealthyThresholdCount: aws.Int64(2),
 			},
@@ -225,7 +223,6 @@ func Test_defaultModelBuilderTask_buildTargetHealthCheck(t *testing.T) {
 				Protocol:                (*elbv2.Protocol)(aws.String("HTTP")),
 				Path:                    aws.String("/"),
 				IntervalSeconds:         aws.Int64(10),
-				TimeoutSeconds:          aws.Int64(10),
 				HealthyThresholdCount:   aws.Int64(3),
 				UnhealthyThresholdCount: aws.Int64(3),
 			},

pkg/service/model_builder_test.go

@@ -165,7 +165,6 @@ func Test_defaultModelBuilderTask_Build(t *testing.T) {
                 "port":"traffic-port",
                 "protocol":"TCP",
                 "intervalSeconds":10,
-                "timeoutSeconds":10,
                 "healthyThresholdCount":3,
                 "unhealthyThresholdCount":3
              },
@@ -324,7 +323,6 @@ func Test_defaultModelBuilderTask_Build(t *testing.T) {
                 "port":"traffic-port",
                 "protocol":"TCP",
                 "intervalSeconds":10,
-                "timeoutSeconds":10,
                 "healthyThresholdCount":3,
                 "unhealthyThresholdCount":3
              },
@@ -523,7 +521,6 @@ func Test_defaultModelBuilderTask_Build(t *testing.T) {
                 "protocol":"HTTP",
                 "path":"/healthz",
                 "intervalSeconds":10,
-                "timeoutSeconds":30,
                 "healthyThresholdCount":2,
                 "unhealthyThresholdCount":2
              },
@@ -546,7 +543,6 @@ func Test_defaultModelBuilderTask_Build(t *testing.T) {
                 "protocol":"HTTP",
                 "path":"/healthz",
                 "intervalSeconds":10,
-                "timeoutSeconds":30,
                 "healthyThresholdCount":2,
                 "unhealthyThresholdCount":2
              },
@@ -852,7 +848,6 @@ func Test_defaultModelBuilderTask_Build(t *testing.T) {
                 "protocol":"HTTP",
                 "path":"/healthz",
                 "intervalSeconds":10,
-                "timeoutSeconds":30,
                 "healthyThresholdCount":2,
                 "unhealthyThresholdCount":2
              },
@@ -875,7 +870,6 @@ func Test_defaultModelBuilderTask_Build(t *testing.T) {
                 "protocol":"HTTP",
                 "path":"/healthz",
                 "intervalSeconds":10,
-                "timeoutSeconds":30,
                 "healthyThresholdCount":2,
                 "unhealthyThresholdCount":2
              },