-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ignore target group health check timeout for NLB #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore target group health check timeout for NLB #1727
Conversation
Hi @kishorj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label tide/merge-method-squash |
18e98d7
to
4ad88ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
Codecov Report
@@ Coverage Diff @@
## main #1727 +/- ##
==========================================
- Coverage 46.72% 46.68% -0.04%
==========================================
Files 110 110
Lines 5984 5980 -4
==========================================
- Hits 2796 2792 -4
- Misses 2923 2925 +2
+ Partials 265 263 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-aws-load-balancer-controller-unit-tes |
@M00nF1sh: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-aws-load-balancer-controller-unit-test |
Fixes #1714
AWS ELBv2 does not support specifying timeout for target group health check config as of now. The default is 10s for TCP/HTTPS protocols, and 6s for HTTP protocol and it cannot be modified. This change will ignore the healthcheck timeout annotation for now.
Tests
service.beta.kubernetes.io/aws-load-balancer-healthcheck-timeout
gets ignored