Skip to content

ignore target group health check timeout for NLB #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

kishorj
Copy link
Collaborator

@kishorj kishorj commented Dec 12, 2020

Fixes #1714
AWS ELBv2 does not support specifying timeout for target group health check config as of now. The default is 10s for TCP/HTTPS protocols, and 6s for HTTP protocol and it cannot be modified. This change will ignore the healthcheck timeout annotation for now.

Tests

  • Verified timeout is 10s for health check protocol HTTPS/TCP, 6s for HTTP
  • Veriried annotation service.beta.kubernetes.io/aws-load-balancer-healthcheck-timeout gets ignored

@k8s-ci-robot
Copy link
Contributor

Hi @kishorj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2020
@kishorj
Copy link
Collaborator Author

kishorj commented Dec 12, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 12, 2020
@kishorj kishorj changed the title ignore target group timeout for NLB ignore target group health check timeout for NLB Dec 12, 2020
@kishorj kishorj force-pushed the main-nlb-ignore-timeout branch from 18e98d7 to 4ad88ae Compare December 12, 2020 03:12
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2020
@codecov-io
Copy link

codecov-io commented Dec 12, 2020

Codecov Report

Merging #1727 (18e98d7) into main (66ae622) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
- Coverage   46.72%   46.68%   -0.04%     
==========================================
  Files         110      110              
  Lines        5984     5980       -4     
==========================================
- Hits         2796     2792       -4     
- Misses       2923     2925       +2     
+ Partials      265      263       -2     
Impacted Files Coverage Δ
pkg/service/model_build_target_group.go 82.97% <ø> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ae622...4ad88ae. Read the comment docs.

Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@M00nF1sh M00nF1sh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh
Copy link
Collaborator

/test pull-aws-load-balancer-controller-unit-tes

@k8s-ci-robot
Copy link
Contributor

@M00nF1sh: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-aws-load-balancer-controller-lint
  • /test pull-aws-load-balancer-controller-unit-test
  • /test pull-aws-load-balancer-controller-e2e-test

Use /test all to run all jobs.

In response to this:

/test pull-aws-load-balancer-controller-unit-tes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kishorj
Copy link
Collaborator Author

kishorj commented Dec 29, 2020

/test pull-aws-load-balancer-controller-unit-test

@k8s-ci-robot k8s-ci-robot merged commit 99b5e74 into kubernetes-sigs:main Dec 29, 2020
@kishorj kishorj deleted the main-nlb-ignore-timeout branch February 25, 2021 21:48
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Support HTTP health checks with nlb-ip type load balancer
4 participants