rewrite TargetGroup filter using ELBV2 tag operation

[Fedomn]

This PR to support controller GC TargetGroup in the internal VPC that without internet access ability.

So i replace Resource Groups Tagging API to ELBV2 DescribeTargetGroups API in targetgroup_group GC function.

Same purpose as #1109

Thanks

[k8s-ci-robot]

Welcome @Fedomn!

It looks like this is your first PR to kubernetes-sigs/aws-alb-ingress-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-alb-ingress-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Fedomn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Fedomn]

/assign @M00nF1sh

[M00nF1sh]

/ok-to-test

[Fedomn]

/retest

[Fedomn]

@M00nF1sh any update about this PR, or i need to migrate this code to v2 first ?

[M00nF1sh]

@Fedomn
sorry for the late reply, we were actively working on v2 and haven't commented on this PR.
The problem with this solution is TargetGroups are created first before attach to LoadBalancers. If there are any error happens before creating listener/listener rules(e.g. a missing TLS certificate), these created TargetGroups will be leaked.

BTW, the v2 already supports private cluster. (it's using ELBv2's tag operation). Do you still want to improve this PR and get merged in v1 or migrate to use v2 😄 .

[Fedomn]

@M00nF1sh thanks for your quick reply, i will improve this PR and use solution same as ELBV2 tagging operations
I think this solution may solve the dangling TargetGroups issue

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedomn
To complete the pull request process, please assign m00nf1sh after the PR has been reviewed.
You can assign the PR to them by writing /assign @m00nf1sh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Fedomn]

/assign @M00nF1sh

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[Fedomn]

just close this PR for v1.
because the v2 already supports private cluster.