Skip to content

Add utility methods and ELBV2 tag operations #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2020
Merged

Add utility methods and ELBV2 tag operations #1385

merged 3 commits into from
Sep 1, 2020

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Sep 1, 2020 •
edited
Loading

Three commits in this PR

  1. add algorithms for string & map: add some utility for string/map operations
  2. add stackID and ListResources into stack: add StackID and ListResources into stack interface
    • stackID: uniquely identify a stack
    • ListResources: list resources for specific type.
  3. add elbv2 tagging operations and pagination wrapper:
    • add shared taggingFilter
    • add elbv2 tagging manager which is responsible for list resources based on tags.
    • add elbv2 pagination operation wrappers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit 28cee8f into kubernetes-sigs:v2_ga Sep 1, 2020
@M00nF1sh M00nF1sh changed the title V2 ga deploy Add utility methods and ELBV2 tag operations Sep 1, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@M00nF1sh @Timothy-Dougherty
V2 ga deploy (kubernetes-sigs#1385)
b66f9ac 
* add algorithms for string & map

* add stackID and ListResources into stack

* add elbv2 tagging operations and pagination wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M00nF1sh @k8s-ci-robot @kishorj