add reconciler for securityGroup rules #1421
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
| return nil, err | ||
| } | ||
| containsPermission := false | ||
| for _, permission := range ipPermissions { |
There was a problem hiding this comment.
what is the expected number of permissions in the worst case?
This could cause a potential bottleneck.
There was a problem hiding this comment.
humm, one securityGroup only have at most 10X permissions.
calculations like these will never be bottleneck :D (networking is)
| @@ -22,23 +23,29 @@ type ResourceManager interface { | |||
| } | |||
|
|
|||
| // NewDefaultResourceManager constructs new defaultResourceManager. | |||
| func NewDefaultResourceManager(k8sClient client.Client, elbv2Client services.ELBV2, logger logr.Logger) *defaultResourceManager { | |||
| func NewDefaultResourceManager(k8sClient client.Client, elbv2Client services.ELBV2, | |||
There was a problem hiding this comment.
Did you modify the main.go as well? if so please include it together.
There was a problem hiding this comment.
update the PR to modify main.go
* add reconciler for securityGroup rules * add networking manager for targetGroupBindings * add sg deployer * fix crd types * add tags handling for securityGroup
raw/descriptionlabel is added for the raw description.