add webhook for TargetGroupBinding and multiple changes to YAMLs #1450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple changes around webhook and CRD yamls.
Webhooks
v1beta1
as our webhook version to support version <1.6.0.spec.targetType
unspecified, set it according to targetGroup in AWS.spec.targetType
are set.spec.targetType
andspec.targetGroupARN
are not mutated.CRD
v1beta1
as our webhook version to support version <1.6.0.trivialVersions==false
, since version<1.13 is not longer supported.Makefile
mutating-webhook-configuration
andvalidating-webhook-configuration
to be justwebhook
yq w -i config/webhook/manifests.yaml -d'*' "metadata.name" "webhook"
yq
can be installed viabrew install yq
ControllerYAML