Skip to content

add webhook for TargetGroupBinding and multiple changes to YAMLs #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2020
Merged

add webhook for TargetGroupBinding and multiple changes to YAMLs #1450

merged 1 commit into from
Sep 26, 2020

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Sep 26, 2020

Multiple changes around webhook and CRD yamls.

Webhooks

  1. we use v1beta1 as our webhook version to support version <1.6.0.
  2. Add two webhook for TargetGroupBinding:
    1. TargetGroupBindingMutator:
      • if spec.targetType unspecified, set it according to targetGroup in AWS.
    2. TargetGroupBindingValidator:
      • validate that spec.targetType are set.
      • validate that spec.targetType and spec.targetGroupARN are not mutated.
  3. added "ARN" and "TARGET-TYPE" to be displayable fields for TargetGroupBinding CRD
  4. enable status field of targetGroupBinding CRD.

CRD

  1. we use v1beta1 as our webhook version to support version <1.6.0.
  2. we make trivialVersions==false, since version<1.13 is not longer supported.

Makefile

  1. upgrade controller-tools to be 0.4.0
  2. use yq to substitute the generate webhook names from mutating-webhook-configuration and validating-webhook-configuration to be just webhook
    • yq w -i config/webhook/manifests.yaml -d'*' "metadata.name" "webhook"
    • on macOS, yq can be installed via brew install yq

ControllerYAML

  1. added a patch to inject fsGroup: 1337 to make controller available for IAM-FOR-SA feature.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 26, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2020
@M00nF1sh M00nF1sh changed the title add webhook for TargetGroupBinding add webhook for TargetGroupBinding and multiple changes to YAMLs Sep 26, 2020
@M00nF1sh M00nF1sh merged commit c8f451a into kubernetes-sigs:v2_ga Sep 26, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants