Make the docker container run as non-root & redact OIDC clientID and clientSecret #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
M00nF1sh
commented
Sep 26, 2020
M00nF1sh
commented
- Make the docker container run as non-root(1002 UID)
- redact OIDC clientID and clientSecret
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
M00nF1sh
changed the title
k8s-ci-robot
added
the
size/M
kishorj
approved these changes
Sep 26, 2020
| @@ -19,6 +19,7 @@ RUN --mount=type=bind,target=. \ | |||
|
|
|||
| FROM amazonlinux:2 as bin-unix | |||
| COPY --from=build /out/controller /controller | |||
| USER 1002 | |||
There was a problem hiding this comment.
why 1002? does this id have to exist or any random id is ok?
There was a problem hiding this comment.
random ID works too, i picked 1002 since it's same as distroless's non-root user
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.