Skip to content

[Bug Fix] Handle TargetGroupBinding's networking changed from non-nil to nil #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Oct 15, 2020

Handle TargetGroupBinding's networking changed from non-nil to nil

Bug:

When TargetGroupBinding's networking changed from non-nil to nil, e.g. changed the Ingress securityGroup from managed to
unmanaged, the securityGroup rule clean up will not happen in-time. (it eventually cleanup when other TargetGroupBinding reconciles)

Changes:

TargetGroupBinding

  1. updating ObservedGeneration for targetGroupBinding.
  2. added handling for TargetGroupBinding with nil networking, we still need to reconcile securityGroup rules as it maybe changed from non-nil to nil, some securityGroup rules might need to be cleanup.
  3. conditional update TargetGroupBinding if the spec changes, and wait for the change to be observed(processed)
  4. fix the node target reconcile to handle draining targets.

Upgrade controller-runtime to v0.6.3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit a0c1562 into kubernetes-sigs:v2_ga Oct 15, 2020
@M00nF1sh M00nF1sh changed the title add ability for targetGroupBinding to change networking [Bug Fix] Handle TargetGroupBinding's networking changed from non-nil to nil Oct 16, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants