multiple bug fixes for v2.0.0-rc4 #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
kishorj
approved these changes
Oct 19, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
* tune TargetGroupBinding requeue duration and deploy order * fix log level * adjust health monitor interval to 15 second * use Optimistic lock for finalizer/pod condition operations * support both clientID and clientId in OIDC secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tune the targetGroupBinding reconcile Requeue behavior
Above requeue strategy will prevent the controller to send too many DescribeTargetHealth API call when targetGroup is not used or securityGroup rules is not setup correctly.
Adjust the resource synthesize order by make TargetGroupBinding synthesize happens after listenerRule, such that when targets are been registered, it's already associated with a LoadBalancer.
Use OptimisticLock via Object's resourceVersion to prevent race condition when updating collection fields.
support both
clientIDandclientId(old one) for OIDC secret.Fix the log level settings. (ctrl.setLogger can only be set once)