Skip to content

feat: add support to set ProtocolVersion based on annotation values #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2020

Conversation

backjo
Copy link
Contributor

@backjo backjo commented Oct 30, 2020

Closes #1586


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2020
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for add support for this.
overall looks good. changes needed in addition to the inline comments 😄:

  1. we should change the buildTargetGroupName in Ingress's model builder to have a protocolVersion passed-in, and use it as a hash component. (since protocolVersion is immutable, we need to create a targetGroup with different name if ppl changes it).

  2. we should change the isSDKTargetGroupRequiresReplacement in deployment/elbv2/target_group_synthesizer.go to be like

if resTG.Spec.ProtocolVersion != nil {
		if awssdk.StringValue(resTG.Spec.ProtocolVersion) != awssdk.SrtingValue(sdkTG.TargetGroup.ProtocolVersion) {
			return true
		}
}

@backjo
Copy link
Contributor Author

backjo commented Nov 13, 2020

sounds good - will tackle these shortly.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2020
@backjo
Copy link
Contributor Author

backjo commented Nov 13, 2020

Addressed the review comments

Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: backjo, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh
Copy link
Collaborator

thanks soo much dude, looks perfect now 👍

@M00nF1sh M00nF1sh merged commit e9691e2 into kubernetes-sigs:main Nov 13, 2020
@backjo backjo deleted the main branch November 14, 2020 01:16
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
…ubernetes-sigs#1589)

* feat: add support to set ProtocolVersion based on annotation values

* Add comment to mock method

* address review comments

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] feature request: support ProtocolVersion on TargetGroups
3 participants