-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix two targetGroup related bug #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,185 @@ | ||
| package ingress | ||
|
|
||
| import ( | ||
| "context" | ||
| "github.com/stretchr/testify/assert" | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/apimachinery/pkg/util/intstr" | ||
| elbv2model "sigs.k8s.io/aws-load-balancer-controller/pkg/model/elbv2" | ||
| "testing" | ||
| ) | ||
|
|
||
| func Test_defaultModelBuildTask_buildTargetGroupName(t *testing.T) { | ||
| type args struct { | ||
| ingKey types.NamespacedName | ||
| svc *corev1.Service | ||
| port intstr.IntOrString | ||
| tgPort int64 | ||
| targetType elbv2model.TargetType | ||
| tgProtocol elbv2model.Protocol | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| args args | ||
| want string | ||
| }{ | ||
| { | ||
| name: "standard case", | ||
| args: args{ | ||
| ingKey: types.NamespacedName{Namespace: "ns-1", Name: "name-1"}, | ||
| svc: &corev1.Service{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "ns-1", | ||
| Name: "name-1", | ||
| UID: "my-uuid", | ||
| }, | ||
| }, | ||
| port: intstr.FromString("http"), | ||
| tgPort: 8080, | ||
| targetType: elbv2model.TargetTypeIP, | ||
| tgProtocol: elbv2model.ProtocolHTTP, | ||
| }, | ||
| want: "k8s-ns1-name1-59797694c2", | ||
| }, | ||
| { | ||
| name: "standard case - port differs", | ||
| args: args{ | ||
| ingKey: types.NamespacedName{Namespace: "ns-1", Name: "name-1"}, | ||
| svc: &corev1.Service{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "ns-1", | ||
| Name: "name-1", | ||
| UID: "my-uuid", | ||
| }, | ||
| }, | ||
| port: intstr.FromInt(80), | ||
| tgPort: 8080, | ||
| targetType: elbv2model.TargetTypeIP, | ||
| tgProtocol: elbv2model.ProtocolHTTP, | ||
| }, | ||
| want: "k8s-ns1-name1-70ebbeea02", | ||
| }, | ||
| { | ||
| name: "standard case - tgPort differs", | ||
| args: args{ | ||
| ingKey: types.NamespacedName{Namespace: "ns-1", Name: "name-1"}, | ||
| svc: &corev1.Service{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "ns-1", | ||
| Name: "name-1", | ||
| UID: "my-uuid", | ||
| }, | ||
| }, | ||
| port: intstr.FromString("http"), | ||
| tgPort: 9090, | ||
| targetType: elbv2model.TargetTypeIP, | ||
| tgProtocol: elbv2model.ProtocolHTTP, | ||
| }, | ||
| want: "k8s-ns1-name1-cf545f64e8", | ||
| }, | ||
| { | ||
| name: "standard case - targetType differs", | ||
| args: args{ | ||
| ingKey: types.NamespacedName{Namespace: "ns-1", Name: "name-1"}, | ||
| svc: &corev1.Service{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "ns-1", | ||
| Name: "name-1", | ||
| UID: "my-uuid", | ||
| }, | ||
| }, | ||
| port: intstr.FromString("http"), | ||
| tgPort: 8080, | ||
| targetType: elbv2model.TargetTypeInstance, | ||
| tgProtocol: elbv2model.ProtocolHTTP, | ||
| }, | ||
| want: "k8s-ns1-name1-e66dadb781", | ||
| }, | ||
| { | ||
| name: "standard case - protocol differs", | ||
| args: args{ | ||
| ingKey: types.NamespacedName{Namespace: "ns-1", Name: "name-1"}, | ||
| svc: &corev1.Service{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "ns-1", | ||
| Name: "name-1", | ||
| UID: "my-uuid", | ||
| }, | ||
| }, | ||
| port: intstr.FromString("http"), | ||
| tgPort: 8080, | ||
| targetType: elbv2model.TargetTypeIP, | ||
| tgProtocol: elbv2model.ProtocolHTTPS, | ||
| }, | ||
| want: "k8s-ns1-name1-3e1463213f", | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| task := &defaultModelBuildTask{} | ||
| got := task.buildTargetGroupName(context.Background(), tt.args.ingKey, tt.args.svc, tt.args.port, tt.args.tgPort, tt.args.targetType, tt.args.tgProtocol) | ||
| assert.Equal(t, tt.want, got) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func Test_defaultModelBuildTask_buildTargetGroupPort(t *testing.T) { | ||
| type args struct { | ||
| targetType elbv2model.TargetType | ||
| svcPort corev1.ServicePort | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| args args | ||
| want int64 | ||
| }{ | ||
| { | ||
| name: "instance targetGroup should use nodePort as port", | ||
| args: args{ | ||
| targetType: elbv2model.TargetTypeInstance, | ||
| svcPort: corev1.ServicePort{ | ||
| Name: "http", | ||
| Port: 80, | ||
| TargetPort: intstr.FromInt(8080), | ||
| NodePort: 32768, | ||
| }, | ||
| }, | ||
| want: 32768, | ||
| }, | ||
| { | ||
| name: "ip targetGroup with numeric targetPort should use targetPort as port", | ||
| args: args{ | ||
| targetType: elbv2model.TargetTypeIP, | ||
| svcPort: corev1.ServicePort{ | ||
| Name: "http", | ||
| Port: 80, | ||
| TargetPort: intstr.FromInt(8080), | ||
| NodePort: 32768, | ||
| }, | ||
| }, | ||
| want: 8080, | ||
| }, | ||
| { | ||
| name: "ip targetGroup with literal targetPort should use 1 as port", | ||
| args: args{ | ||
| targetType: elbv2model.TargetTypeIP, | ||
| svcPort: corev1.ServicePort{ | ||
| Name: "http", | ||
| Port: 80, | ||
| TargetPort: intstr.FromString("http"), | ||
| NodePort: 32768, | ||
| }, | ||
| }, | ||
| want: 1, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| task := &defaultModelBuildTask{} | ||
| got := task.buildTargetGroupPort(context.Background(), tt.args.targetType, tt.args.svcPort) | ||
| assert.Equal(t, tt.want, got) | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.