Skip to content

add service event handler for targetGroupBinding #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Nov 20, 2020

add service event handler for targetGroupBinding.

  1. Service changes should trigger enqueue for TGB of instance targetType since nodePort might changed.
  2. we only enqueue TGB of instance targetType for service creation and deletion since IP targetType is driving by the endpoints object. (service creation and deletion will results in endpoints creation and deletion)
    Fix new nodeports not discovered #1651

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #1678 (0386cd3) into main (dbc8f00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1678   +/-   ##
=======================================
  Coverage   46.11%   46.11%           
=======================================
  Files         110      110           
  Lines        5920     5920           
=======================================
  Hits         2730     2730           
  Misses       2926     2926           
  Partials      264      264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc8f00...0386cd3. Read the comment docs.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishorj, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit fbbeffc into kubernetes-sigs:main Nov 21, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new nodeports not discovered
4 participants