-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add COIP support for ALB on outpost #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
==========================================
+ Coverage 46.19% 46.34% +0.14%
==========================================
Files 110 110
Lines 5933 5957 +24
==========================================
+ Hits 2741 2761 +20
- Misses 2927 2930 +3
- Partials 265 266 +1
Continue to review full report at Codecov.
|
|
||
!!!warning "" | ||
This annotation should be treated as immutable. To remove or change coIPv4Pool, you need to recreate Ingress. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will be this surfaced to the user in the current approach if they still end up changing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a check for drifted settings.
Now customer will saw errors in controller log and Ingress events if they changed it.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fawadkhaliq, M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add COIP support for ALB on outpost * check for drifted coIPv4Pool settings
add COIP support for ALB on outpost
This PR supports to specify the ID of the customer-owned address pool via annotation
alb.ingress.kubernetes.io/customer-owned-ipv4-pool
.Note: coIPv4 pool for ALB should be immutable.
Test done