docs: update helm install command #1793
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @hi-rustin! |
|
Hi @hi-rustin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
Codecov Report
@@ Coverage Diff @@
## main #1793 +/- ##
=======================================
Coverage 46.76% 46.76%
=======================================
Files 110 110
Lines 5988 5988
=======================================
Hits 2800 2800
Misses 2925 2925
Partials 263 263 Continue to review full report at Codecov.
|
|
/cc @M00nF1sh |
docs/deploy/installation.md
Outdated
| @@ -66,7 +66,7 @@ curl -o iam-policy.json https://raw.githubusercontent.com/kubernetes-sigs/aws-lo | |||
| ``` | |||
| 1. Install the helm chart | |||
| ``` | |||
| helm install eks/aws-load-balancer-controller | |||
| helm install eks/aws-load-balancer-controller --generate-name --set clusterName=<cluster-name> | |||
There was a problem hiding this comment.
- default name instead of the
--generate-namelooks better to me - lets suggest a namespace, for example -n kube-system
There was a problem hiding this comment.
* default name instead of the `--generate-name` looks better to me
It does not use the default name, but prompts you that you must specify a name or use --generate-name.
My env:
➜ ~ helm version
version.BuildInfo{Version:"v3.3.2", GitCommit:"e5077257b6ca106d1f65652b4ca994736d221ab1", GitTreeState:"dirty", GoVersion:"go1.15.2"}
There was a problem hiding this comment.
* lets suggest a namespace, for example -n kube-system
done
There was a problem hiding this comment.
by default name, I meant to use aws-load-balancer-controller. For example -
helm install aws-load-balancer-controller eks/aws-load-balancer-controller -n kube-system --set clusterName=<cluster-name>
|
/cc @kishorj |
|
@hi-rustin: GitHub didn't allow me to request PR reviews from the following users: kishorj. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hi-rustin, kishorj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* docs: update helm install command * docs: suggest a namespace * docs: specify a name
Update helm install command.
We need to specify the name or use the generated name, and in addition we need to set the cluster name.