Skip to content

docs: Update v1 to v2 migration guide to include example command for updating SG rules #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Feb 5, 2021

Adds a command to the v1 to v2 upgrade guide documentation for updating the SG rules created by alb ingress controller v1 to include the elbv2.k8s.aws/targetGroupBinding=shared description.

I'm not 100% sure the formatting is correct on the markdown, but it should be easy to update if not.

…ng SG rules

Adds a command to the v1 to v2 upgrade guide documentation for updating the SG rules created by alb ingress controller v1 to include the elbv2.k8s.aws/targetGroupBinding=shared description.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chancez
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @chancez!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @chancez. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2021
@chancez chancez changed the title migration: Update v1 to v2 docs to include example command for updating SG rules docs: Update v1 to v2 migration guide to include example command for updating SG rules Feb 5, 2021
@kishorj
Copy link
Collaborator

kishorj commented Feb 16, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2021
@chancez
Copy link
Contributor Author

chancez commented Feb 16, 2021

Test failure is unrelated to my changes.

@kishorj
Copy link
Collaborator

kishorj commented Feb 16, 2021

Test failure is unrelated to my changes.

@chancez, Thanks for the PR, the test failures are not due to your changes. I will get your changes for 2.2.0 release.

@kishorj
Copy link
Collaborator

kishorj commented Feb 17, 2021

/test pull-aws-load-balancer-controller-e2e-test

@k8s-ci-robot
Copy link
Contributor

@chancez: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-aws-load-balancer-controller-e2e-test 377a1c7 link /test pull-aws-load-balancer-controller-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kishorj kishorj merged commit 9006bfc into kubernetes-sigs:main Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants