remove depericated apiVersoin

[ngoyal16]

Depericated apiVersion removed in Ingress resource

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @ngoyal16!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ngoyal16. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ngoyal16]

/assign @M00nF1sh

[ngoyal16]

/retest

[k8s-ci-robot]

@ngoyal16: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[M00nF1sh]

@ngoyal16
Thanks for making this PR.
would mind change it to networking.k8s.io/v1beta1 (the backend syntax differs from v1 slightly as well).
networking.k8s.io/v1 is not available for old supported EKS versions(e.g. 1.17) currently, and this file is used in EKS docs.

Another optional alternative is create another file like docs/examples/2048/2048_full_latest.yaml for latest apis.

[ngoyal16]

@M00nF1sh I have chanced the api version for now.

[codecov-io]

Codecov Report

Merging #1850 (6f13eed) into main (88b90c0) will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   47.62%   47.98%   +0.35%     
==========================================
  Files         110      110              
  Lines        6110     6177      +67     
==========================================
+ Hits         2910     2964      +54     
- Misses       2931     2938       +7     
- Partials      269      275       +6     

Impacted Files	Coverage Δ
pkg/service/model_build_target_group.go	82.31% <0.00%> (-0.67%)	⬇️
pkg/deploy/elbv2/target_group_binding_manager.go	0.00% <0.00%> (ø)
pkg/service/model_builder.go	81.48% <0.00%> (+2.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b90c0...0b8ab43. Read the comment docs.

[tomislater]

Hmm, is this example valid?

We use networking.k8s.io/v1beta1, but the section

service:
  name: service-2048
  port:
    number: 80

is valid only in networking.k8s.io/v1 as far as I know.

In 1.18 we still must use networking.k8s.io/v1beta1: https://v1-18.docs.kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource

Since 1.19 we can use networking.k8s.io/v1 (it will be removed in 1.22), and in this version we must use service.name, service.port.number, etc.: https://v1-19.docs.kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource

BTW. Can I create/update on my EKS Cluster (1.19) an Ingress object (networking.k8s.io/v1) and aws-load-balancer-controller will create (or update existing one) ALB on AWS?

I have some Ingress objects currently on my cluster (networking.k8s.io/v1beta1) and I wonder if I can use a new version (networking.k8s.io/v1).

[ngoyal16]

@tomislater issue fixed.

[M00nF1sh]

/lgtm
thanks for updating this :D

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, ngoyal16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [M00nF1sh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment