Add support for specifying the load balancer's name via annotation #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
This adds a new "aws-load-balancer-name" annotation that can be used to specify the associated load balancer's name, overriding the default name format. Some implementation notes: * This doesn't perform any input validation on the annotation value to ensure it matches the allowed naming format. I'm happy to add this but didnt see validation on any other annotation value strings. * Adding or updating the annotation on existing ingresses has no effect once a load balancer already exists.
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
kishorj
added
the
tide/merge-method-squash
|
thanks for contributing this feature, really valuable 👍 for target-group-name, i wonder the use case to explicitly control it (it's also complicated when IngressGroup is involved). i think we can pending that until there is a real use case for control over targetGroup names. (For loadbalancer, the use case exists since the name impacts DNS name) |
kishorj
reviewed
Mar 12, 2021
| @@ -48,6 +48,7 @@ type TargetGroupHC struct { | |||
| } | |||
|
|
|||
| type LoadBalancerExpectation struct { | |||
| Name *string | |||
There was a problem hiding this comment.
nit: for consistency, string instead of a pointer looks better to me
kishorj
approved these changes
Mar 13, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Mar 19, 2021
Closed
Closed
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
…ubernetes-sigs#1880) This adds a new "aws-load-balancer-name" annotation that can be used to specify the associated load balancer's name, overriding the default name format. Some implementation notes: * This doesn't perform any input validation on the annotation value to ensure it matches the allowed naming format. I'm happy to add this but didnt see validation on any other annotation value strings. * Adding or updating the annotation on existing ingresses has no effect once a load balancer already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new "aws-load-balancer-name" annotation that can be used to specify the associated load balancer's name, overriding the default name format.
Some implementation notes:
fixes #1483