Skip to content

Support custom ALB name via annotation #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

kishorj
Copy link
Collaborator

@kishorj kishorj commented Mar 20, 2021

Fixes #1483

Add support to specify custom ALB name via the annotation alb.ingress.kubernetes.io/name. This annotation can only be specified during ingress/ingress group creation. If the controller detects an existing ALB for the stack, this annotation has no effect.

Testing

  • load balancer gets created with the custom name if specified via the annotation
  • lb name doesn't get modified after creation
  • conflicting names aren't allowed in the same group
  • name gets auto-generated if annotation is not specified

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2021
@k8s-ci-robot k8s-ci-robot requested a review from M00nF1sh March 20, 2021 01:11
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2021
@codecov-io
Copy link

codecov-io commented Mar 20, 2021

Codecov Report

Merging #1899 (1928643) into main (012e132) will increase coverage by 0.11%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
+ Coverage   48.79%   48.90%   +0.11%     
==========================================
  Files         113      113              
  Lines        6349     6361      +12     
==========================================
+ Hits         3098     3111      +13     
+ Misses       2978     2977       -1     
  Partials      273      273              
Impacted Files Coverage Δ
pkg/ingress/model_build_load_balancer.go 51.40% <86.66%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012e132...1928643. Read the comment docs.

@kishorj kishorj marked this pull request as ready for review March 20, 2021 01:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2021
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 20, 2021
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 12b5676 into kubernetes-sigs:main Apr 8, 2021
@kishorj kishorj deleted the alb-name branch April 8, 2021 23:38
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.90%. Comparing base (012e132) to head (3e8d91c).
Report is 677 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/model_build_load_balancer.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
+ Coverage   48.79%   48.90%   +0.11%     
==========================================
  Files         113      113              
  Lines        6349     6361      +12     
==========================================
+ Hits         3098     3111      +13     
+ Misses       2978     2977       -1     
  Partials      273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add the option to specify a load balancer name
5 participants