-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Support custom ALB name via annotation #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
+ Coverage 48.79% 48.90% +0.11%
==========================================
Files 113 113
Lines 6349 6361 +12
==========================================
+ Hits 3098 3111 +13
+ Misses 2978 2977 -1
Partials 273 273
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
+ Coverage 48.79% 48.90% +0.11%
==========================================
Files 113 113
Lines 6349 6361 +12
==========================================
+ Hits 3098 3111 +13
+ Misses 2978 2977 -1
Partials 273 273 ☔ View full report in Codecov by Sentry. |
Fixes #1483
Add support to specify custom ALB name via the annotation
alb.ingress.kubernetes.io/name
. This annotation can only be specified during ingress/ingress group creation. If the controller detects an existing ALB for the stack, this annotation has no effect.Testing