Skip to content

Highlight the need to tag subnets #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2021
Merged

Highlight the need to tag subnets #1904

merged 2 commits into from
Apr 7, 2021

Conversation

isqrd
Copy link
Contributor

@isqrd isqrd commented Mar 26, 2021

While this info is part of the AWS eks userguid documentation, I think it is worth including the need to tag subnets with kubernetes.io/role/ tag here as well.

@k8s-ci-robot
Copy link
Contributor

Welcome @isqrd!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @isqrd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2021
kishorj
kishorj reviewed Mar 27, 2021
View reviewed changes
docs/guide/service/nlb_ip_mode.md Outdated
@@ -33,5 +33,22 @@ to enable proxy protocol v2, apply the following annotation to your service:
service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: "*"
```

## Subnet tagging requirements
You must tag the subnets you wish to attach your ELB to with the following tags.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subnets tags are useful only for auto-discovery.

docs/guide/service/nlb_ip_mode.md Outdated
## Subnet tagging requirements
You must tag the subnets you wish to attach your ELB to with the following tags.
- For any subnet used by node group.
- **Key:** *kubernetes.io/cluster/$CLUSTER_NAME*
Copy link
Collaborator

@kishorj kishorj Mar 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cluster tag is optional. In case of ties (for example there are multiple subnets in the same AZ), auto-discovery will prefer the one with the cluster tag. This has been the behavior since EKS 1.19 for in-tree and v2.1.2 release of the lb controller (ref https://docs.aws.amazon.com/eks/latest/userguide/load-balancing.html)

@kishorj
Copy link
Collaborator

kishorj commented Mar 27, 2021

Lets reference the file deploy/subnet_discovery.md instead.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2021
@kishorj
Copy link
Collaborator

kishorj commented Apr 7, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isqrd, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 92744fb into kubernetes-sigs:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj left review comments

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isqrd @k8s-ci-robot @kishorj