-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: update Subnet discovery with optional tag #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release 2.1.2 included changes that relaxed requirements on subnet [tagging](kubernetes-sigs#1773) with the cluster name.
Welcome @kreempuff! |
Hi @kreempuff. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #1943 +/- ##
=======================================
Coverage 48.95% 48.95%
=======================================
Files 122 122
Lines 6690 6690
=======================================
Hits 3275 3275
Misses 3132 3132
Partials 283 283 Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, kreempuff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do I have to do anything to deploy the docs? |
* docs: update Subnet discovery with optional tag Release 2.1.2 included changes that relaxed requirements on subnet [tagging](kubernetes-sigs#1773) with the cluster name. * docs: update based of PR feedback
Release 2.1.2 included changes that relaxed requirements on subnet tagging
with the cluster name.