Skip to content

Add flags to set server key and certificate #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021

Conversation

lxlxok
Copy link
Contributor

@lxlxok lxlxok commented May 6, 2021

This PR resolve #1942

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from kishorj and M00nF1sh May 6, 2021 02:37
@k8s-ci-robot
Copy link
Contributor

Welcome @lxlxok!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @lxlxok. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2021
@kishorj
Copy link
Collaborator

kishorj commented May 6, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #1983 (5f5eee5) into main (eb2c151) will decrease coverage by 0.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
- Coverage   49.29%   48.84%   -0.45%     
==========================================
  Files         125      130       +5     
  Lines        6875     6997     +122     
==========================================
+ Hits         3389     3418      +29     
- Misses       3211     3302      +91     
- Partials      275      277       +2     
Impacted Files Coverage Δ
pkg/config/runtime_config.go 0.00% <0.00%> (ø)
pkg/ingress/model_build_load_balancer.go 48.83% <0.00%> (-0.72%) ⬇️
pkg/deploy/elbv2/target_group_manager.go 47.05% <0.00%> (-0.71%) ⬇️
pkg/ingress/model_build_managed_sg.go 67.30% <0.00%> (-0.49%) ⬇️
pkg/ingress/model_build_target_group.go 72.97% <0.00%> (-0.31%) ⬇️
pkg/deploy/elbv2/load_balancer_manager.go 20.00% <0.00%> (-0.25%) ⬇️
pkg/ingress/model_builder.go 62.65% <0.00%> (-0.17%) ⬇️
pkg/deploy/ec2/security_group_manager.go 4.65% <0.00%> (-0.12%) ⬇️
pkg/deploy/elbv2/listener_manager.go 1.12% <0.00%> (-0.02%) ⬇️
pkg/ingress/model_build_actions.go 51.97% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2c151...5f5eee5. Read the comment docs.

@lxlxok
Copy link
Contributor Author

lxlxok commented May 6, 2021

/retest

@lxlxok
Copy link
Contributor Author

lxlxok commented May 10, 2021

Hi @kishorj, thanks for your review, all the comments have been addressed. PTAL

@kishorj
Copy link
Collaborator

kishorj commented May 10, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, lxlxok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8b52408 into kubernetes-sigs:main May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose flag to configure certs for webhook
4 participants