Skip to content

add event handler for ingressClass&ingressClassParams events #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2021
Merged

add event handler for ingressClass&ingressClassParams events #1991

merged 4 commits into from
May 14, 2021

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented May 7, 2021 •
edited
Loading

add event handler for ingressClass & ingressClassParams events If IngressClass is optional.

  1. IngressClassParams changes will trigger IngressClass change.
  2. IngressClass will trigger Ingress change

Test done:

  1. Tested both case above.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2021
@k8s-ci-robot k8s-ci-robot requested a review from kishorj May 7, 2021 17:42
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021 •
edited
Loading

Codecov Report

Merging #1991 (a72e0b7) into main (4cb7510) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
+ Coverage   48.82%   48.91%   +0.08%     
==========================================
  Files         130      130              
  Lines        6998     7010      +12     
==========================================
+ Hits         3417     3429      +12     
  Misses       3303     3303              
  Partials      278      278
Impacted Files Coverage Δ
pkg/ingress/reference_indexer.go 73.07% <100.00%> (+8.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb7510...a72e0b7. Read the comment docs.

@M00nF1sh M00nF1sh force-pushed the main_ingclass_event branch from ac393d3 to e94999b Compare May 7, 2021 17:48
@kishorj
Copy link
Collaborator

kishorj commented May 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 7, 2021
@kishorj
Copy link
Collaborator

kishorj commented May 10, 2021

/retest

1 similar comment
@kishorj
Copy link
Collaborator

kishorj commented May 11, 2021

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2021
@M00nF1sh M00nF1sh force-pushed the main_ingclass_event branch from 89fbee0 to f8688c2 Compare May 13, 2021 17:35
@M00nF1sh
Copy link
Collaborator Author

/test pull-aws-load-balancer-controller-e2e-test

3 similar comments
@M00nF1sh
Copy link
Collaborator Author

/test pull-aws-load-balancer-controller-e2e-test

@M00nF1sh
Copy link
Collaborator Author

/test pull-aws-load-balancer-controller-e2e-test

@M00nF1sh
Copy link
Collaborator Author

/test pull-aws-load-balancer-controller-e2e-test

@M00nF1sh M00nF1sh force-pushed the main_ingclass_event branch from 6783934 to 1a9dc71 Compare May 14, 2021 00:38
@M00nF1sh
Copy link
Collaborator Author

/test pull-aws-load-balancer-controller-e2e-test

@M00nF1sh M00nF1sh force-pushed the main_ingclass_event branch from 1a9dc71 to 5c8eb08 Compare May 14, 2021 02:29
@kishorj
Copy link
Collaborator

kishorj commented May 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit edaddf5 into kubernetes-sigs:main May 14, 2021
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@M00nF1sh @Timothy-Dougherty
add event handler for ingressClass&ingressClassParams events (kuberne…
ba448d4 
…tes-sigs#1991)

* add event handler for ingressClass&ingressClassParams events

* update crd in test cases

* make ingressClass optional

* force deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M00nF1sh @codecov-commenter @kishorj @k8s-ci-robot