-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Docs update about IngressClass & new controller-level flags #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
+ Coverage 48.82% 48.98% +0.15%
==========================================
Files 130 130
Lines 6998 6998
==========================================
+ Hits 3417 3428 +11
+ Misses 3303 3292 -11
Partials 278 278
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
I looked through this and have suggested a mixture of
- tweaks to grammar
- wording revisions, based on my understanding of what the existing text means
I hope this feedback is helpful; if I have obviously misunderstood some parts, please let me know.
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
@sftim |
/lgtm |
…es-sigs#2002) * add docs for new flags * add documentation for IngressClass & new controller-flags * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/deploy/configurations.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> * Update docs/guide/ingress/ingress_class.md Co-authored-by: Tim Bannister <[email protected]> Co-authored-by: Tim Bannister <[email protected]>
Docs update about IngressClass & new controller-level flags.