Skip to content

Docs update about IngressClass & new controller-level flags #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 13, 2021

Conversation

M00nF1sh
Copy link
Collaborator

Docs update about IngressClass & new controller-level flags.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2021
@k8s-ci-robot k8s-ci-robot requested a review from kishorj May 12, 2021 20:05
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #2002 (a4e65fe) into main (4cb7510) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head a4e65fe differs from pull request most recent head 9ac6b89. Consider uploading reports for the commit 9ac6b89 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2002      +/-   ##
==========================================
+ Coverage   48.82%   48.98%   +0.15%     
==========================================
  Files         130      130              
  Lines        6998     6998              
==========================================
+ Hits         3417     3428      +11     
+ Misses       3303     3292      -11     
  Partials      278      278              
Impacted Files Coverage Δ
pkg/networking/vpc_resolver.go 73.33% <0.00%> (+73.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb7510...9ac6b89. Read the comment docs.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

I looked through this and have suggested a mixture of

  • tweaks to grammar
  • wording revisions, based on my understanding of what the existing text means

I hope this feedback is helpful; if I have obviously misunderstood some parts, please let me know.

M00nF1sh and others added 18 commits May 13, 2021 11:59
@M00nF1sh
Copy link
Collaborator Author

@sftim
Thanks so much for all these valuable suggestion 😄

@kishorj
Copy link
Collaborator

kishorj commented May 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2021
@M00nF1sh M00nF1sh merged commit 6bf1aa9 into kubernetes-sigs:main May 13, 2021
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
…es-sigs#2002)

* add docs for new flags

* add documentation for IngressClass & new controller-flags

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/deploy/configurations.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

* Update docs/guide/ingress/ingress_class.md

Co-authored-by: Tim Bannister <[email protected]>

Co-authored-by: Tim Bannister <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants