Add MinLength validation to TargetGroupARN

[shuheiktgw]

Close #1997

I added MinLength validation to TargetGroupARN. Thank you for your review! 👍

[k8s-ci-robot]

Welcome @shuheiktgw!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @shuheiktgw. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kishorj]

/ok-to-test

[codecov-commenter]

Codecov Report

Merging #2035 (ab912a1) into main (68f7db5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2035   +/-   ##
=======================================
  Coverage   49.23%   49.23%           
=======================================
  Files         130      130           
  Lines        7036     7036           
=======================================
  Hits         3464     3464           
  Misses       3294     3294           
  Partials      278      278           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f7db5...ab912a1. Read the comment docs.

[M00nF1sh]

i believe it used to be kubebuilder:validation:MinLength=1 did +kubebuilder:validation:MinLength:=1 works as well? e.g. in https://book.kubebuilder.io/reference/generating-crd.html their example here.

[shuheiktgw]

Thank you for your review! It seems both := and = output the same manifests and https://book.kubebuilder.io/reference/markers/crd-validation.html uses := instead of =. I updated it to use = instead!

[M00nF1sh]

thanks for contributing this :D

[M00nF1sh]

/lgtm
/approve
thanks a lot 😄

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, shuheiktgw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [M00nF1sh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment