-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add aws-load-balancer-controller Helm chart #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @fawadkhaliq! |
Hi @fawadkhaliq. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @M00nF1sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fawadkhaliq, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Codecov Report
@@ Coverage Diff @@
## main #2088 +/- ##
=======================================
Coverage 49.23% 49.23%
=======================================
Files 130 130
Lines 7036 7036
=======================================
Hits 3464 3464
Misses 3294 3294
Partials 278 278 Continue to review full report at Codecov.
|
Issue
#2087
Description
Helm chart is the preferred way of packaging and installing the AWS Load Balancer controller. Not having the chart source code in the aws-load-balancer-controller repo leads to reactive/post-merge/post-release/manual validation of the chart. We would like maintain the charts in the controller repo and sync with the eks-charts on releases (controller release or just a Helm chart release). This will also allow us to 1) test helm charts in integration and end to end tests 2) avoid the need to manually copy over CRD changes
This PR adds the AWS Load Balancer controller Helm chart. Next, we will add scripts to sync Helm charts with eks-charts on release and migrate the existing integration tests to setup controller using Helm instead