Restrict subnet auto-discovery to new LB creation only #2125

oliviassss · 2021-07-14T20:58:47Z

Issue

#2056

Description

Restrict the subnet auto-discovery to new load balancer creation on ingress side.

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

k8s-ci-robot · 2021-07-14T20:58:55Z

Welcome @oliviassss!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-07-14T20:58:55Z

Hi @oliviassss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov-commenter · 2021-07-14T21:38:19Z

Codecov Report

Merging #2125 (590c230) into main (9f4eae5) will increase coverage by 0.06%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
+ Coverage   49.52%   49.59%   +0.06%     
==========================================
  Files         130      130              
  Lines        7065     7084      +19     
==========================================
+ Hits         3499     3513      +14     
- Misses       3284     3287       +3     
- Partials      282      284       +2

Impacted Files	Coverage Δ
pkg/ingress/model_builder.go	`62.34% <50.00%> (-0.32%)`	⬇️
pkg/ingress/model_build_load_balancer.go	`50.86% <69.23%> (+2.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4eae5...590c230. Read the comment docs.

kishorj · 2021-07-14T23:32:24Z

/ok-to-test

kishorj · 2021-07-14T23:56:54Z

pkg/ingress/model_builder_test.go

+								LoadBalancerArn: awssdk.String("lb-1"),
+								AvailabilityZones: []*elbv2sdk.AvailabilityZone{
+									{
+										SubnetId: awssdk.String("subnet-a"),


could you use different subnet names in this case? I see 'subnet-a' and 'subnet-b' are used for other tests as well.

Changed to 'subnet-e' and 'subent-f' in this case.

kishorj · 2021-07-15T00:01:44Z

pkg/ingress/model_builder_test.go

+			ctrl := gomock.NewController(t)
+			defer ctrl.Finish()
+
+			elbv2Client := services.NewMockELBV2(ctrl)


Why not use MockTaggingManager instead? The tests are simpler that way.

Thanks for your advice. Have changed to use MockTaggingManager.

kishorj · 2021-07-15T16:53:21Z

/lgtm
/approve

k8s-ci-robot · 2021-07-15T16:53:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2021

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2021

k8s-ci-robot requested review from kishorj and M00nF1sh July 14, 2021 20:59

oliviassss changed the title ~~Olivia/subnet discovery~~ Restrict subnet auto-discovery to new LB creation only Jul 14, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2021

kishorj reviewed Jul 15, 2021

View reviewed changes

oliviassss force-pushed the olivia/subnet_discovery branch from 590c230 to 5d0d12f Compare July 15, 2021 06:44

Restrict subnet auto-discovery to new LB

36196e1

oliviassss force-pushed the olivia/subnet_discovery branch from 5d0d12f to 36196e1 Compare July 15, 2021 06:50

kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2021

k8s-ci-robot assigned kishorj Jul 15, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021

k8s-ci-robot merged commit 4982070 into kubernetes-sigs:main Jul 15, 2021

oliviassss mentioned this pull request Dec 1, 2021

call subnet auto discovery when lb scheme changes #2387

Merged

6 tasks

oliviassss mentioned this pull request Apr 28, 2023

REQUEST: New membership for @oliviassss kubernetes/org#4183

Closed

9 tasks

Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023

Restrict subnet auto-discovery to new LB (kubernetes-sigs#2125)

a3739f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Restrict subnet auto-discovery to new LB creation only #2125

Restrict subnet auto-discovery to new LB creation only #2125

Uh oh!

oliviassss commented Jul 14, 2021 •

edited

Loading

Uh oh!

k8s-ci-robot commented Jul 14, 2021

Uh oh!

k8s-ci-robot commented Jul 14, 2021

Uh oh!

codecov-commenter commented Jul 14, 2021

Uh oh!

kishorj commented Jul 14, 2021

Uh oh!

kishorj Jul 14, 2021

Uh oh!

oliviassss Jul 15, 2021

Uh oh!

kishorj Jul 15, 2021

Uh oh!

oliviassss Jul 15, 2021

Uh oh!

kishorj commented Jul 15, 2021

Uh oh!

k8s-ci-robot commented Jul 15, 2021

Uh oh!

Uh oh!

Restrict subnet auto-discovery to new LB creation only #2125

Restrict subnet auto-discovery to new LB creation only #2125

Uh oh!

Conversation

oliviassss commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Uh oh!

k8s-ci-robot commented Jul 14, 2021

Uh oh!

k8s-ci-robot commented Jul 14, 2021

Uh oh!

codecov-commenter commented Jul 14, 2021

Codecov Report

Uh oh!

kishorj commented Jul 14, 2021

Uh oh!

kishorj Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

oliviassss Jul 15, 2021

Choose a reason for hiding this comment

Uh oh!

kishorj Jul 15, 2021

Choose a reason for hiding this comment

Uh oh!

oliviassss Jul 15, 2021

Choose a reason for hiding this comment

Uh oh!

kishorj commented Jul 15, 2021

Uh oh!

k8s-ci-robot commented Jul 15, 2021

Uh oh!

Uh oh!

oliviassss commented Jul 14, 2021 •

edited

Loading