-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add deployment update strategy to aws-load-balancer-controller #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @kirrmann! |
Hi @kirrmann. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @M00nF1sh |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kirrmann, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #2130 +/- ##
=======================================
Coverage 49.59% 49.59%
=======================================
Files 130 130
Lines 7084 7084
=======================================
Hits 3513 3513
Misses 3287 3287
Partials 284 284 Continue to review full report at Codecov.
|
/lgtm |
…netes-sigs#2130) * Add strategy to deployment template * Add updateStrategy to values * Increase chart version * Add updateStrategy to README
Description
Simple PR to add optional configuration for strategy in the deployment template
Checklist
README.md
, or thedocs
directory)