-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add support for pods supported by IPv4Prefix on ENI #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2137 +/- ##
==========================================
+ Coverage 49.59% 50.03% +0.44%
==========================================
Files 130 131 +1
Lines 7084 7119 +35
==========================================
+ Hits 3513 3562 +49
+ Misses 3287 3273 -14
Partials 284 284
Continue to review full report at Codecov.
|
/hold |
/lgtm |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fawadkhaliq, kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stevehipwell, we backported the fix to the v2.2 release since it was a critical fix. |
Thanks @kishorj. I worked this out by checking the released code, which is why I was suggesting that the milestone be changed to make it easier for anyone else to see that. |
Description
EC2 recently introduced supports for IPv4Prefix on ENI, which will be supported by EKS VPC CNI soon.
This PR add support for pods supported by IPv4Prefix on ENI.
Previously, the pod ENI resolve logic works by filter ENIs in VPC that contains pod's IPv4Addresses. This approach don't work for IPv4Prefix case.
with this PR, we changed to described the instance on which the pod is running on, and find the ENI supporting the pod's IP address.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯