-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve contributing documentation #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @akuzni2! |
Hi @akuzni2. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello - this is my first PR against any large OS project. Excited to get started as I saw a "good first issue" that I would like to contribute to and wanted to make sure I could follow the PR process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akuzni2, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
Contributing.md document had a broken link to the "cheat sheet".
Description
CONTRIBUTING.md document had a broken link to the "cheat sheet". Reformatted
Getting Started
section a little to make it slightly easier to read.Since the cheat-sheet markdown document looks like it has various translations, I've updated the link to point to the directory which by default will display the English cheat-sheet markdown document but will also display the various language translations as well.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯