cert-manager apiversion to v1 #2189

cw-sakamoto · 2021-08-22T07:29:26Z

Signed-off-by: cw-sakamoto [email protected]

Issue

Description

I recreate PR for aws/eks-charts#579.

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

Signed-off-by: cw-sakamoto <[email protected]>

k8s-ci-robot · 2021-08-22T07:29:33Z

Hi @cw-sakamoto. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov-commenter · 2021-08-22T07:36:18Z

Codecov Report

Merging #2189 (1ef574c) into main (1eb373b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2189   +/-   ##
=======================================
  Coverage   53.55%   53.55%           
=======================================
  Files         136      136           
  Lines        7607     7607           
=======================================
  Hits         4074     4074           
  Misses       3217     3217           
  Partials      316      316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb373b...1ef574c. Read the comment docs.

kishorj

We'd also need to modify the installation guide to install the correct version of the cert-manager. Also need to change config/certmanager/certificate.yaml

kishorj · 2021-08-25T23:18:51Z

/ok-to-test

Signed-off-by: cw-sakamoto <[email protected]>

cw-sakamoto · 2021-08-27T03:39:50Z

@kishorj
I have modified the files related to cert-manager, please check them.

kishorj

I have a concern regarding setups with existing cert-manager installation. If we can address the issue I've commented below, I feel comfortable to include the changes as part of next release.

kishorj · 2021-09-07T22:05:10Z

helm/aws-load-balancer-controller/templates/webhook.yaml

@@ -142,7 +142,7 @@ data:
  tls.crt: {{ $tls.clientCert }}
  tls.key: {{ $tls.clientKey }}
 {{- else }}
-apiVersion: cert-manager.io/v1alpha2
+apiVersion: cert-manager.io/v1


Customers with old cert-manager setup will not be able to upgrade to the new load balancer controller chart since the old setup doesn't recognize v1 version. This will confuse the end users.

Is it possible to use .Capabilities.APIVersions.Has to use v1 only if support is available?

It can be done as follows, but --validate is required if we want to use CRD apiversion for .Capabilities.APIVersions.Has.

ef83d66

helm template aws-load-balancer-controller ./aws-load-balancer-controller -f settings.yaml -n kube-system --validate

Signed-off-by: cw-sakamoto <[email protected]>

kishorj · 2021-10-04T22:32:16Z

/lgtm

kishorj · 2021-10-04T23:32:37Z

/approve

k8s-ci-robot · 2021-10-04T23:32:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cw-sakamoto, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* cert-manager apiversion to v1 Signed-off-by: cw-sakamoto <[email protected]> * Add .Capabilities.APIVersions.Has for cert-manager template Signed-off-by: cw-sakamoto <[email protected]> * modify for cert-manager helm template Signed-off-by: cw-sakamoto <[email protected]> Co-authored-by: Kishor Joshi <[email protected]>

cert-manager apiversion to v1

8ee8311

Signed-off-by: cw-sakamoto <[email protected]>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2021

k8s-ci-robot requested review from kishorj and M00nF1sh August 22, 2021 07:29

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2021

cw-sakamoto mentioned this pull request Aug 22, 2021

[aws-load-balancer-controller]cert-manager apiversion to v1 aws/eks-charts#579

Closed

4 tasks

kishorj reviewed Aug 25, 2021

View reviewed changes

modify cert-manager version and apiversion

34f7c26

Signed-off-by: cw-sakamoto <[email protected]>

cw-sakamoto force-pushed the change_cert-manager_apiversion branch from cb5891e to 34f7c26 Compare August 27, 2021 03:37

kishorj reviewed Sep 7, 2021

View reviewed changes

cw-sakamoto added 2 commits September 8, 2021 16:18

Add .Capabilities.APIVersions.Has for cert-manager template

fe80000

Signed-off-by: cw-sakamoto <[email protected]>

modify for cert-manager helm template

ef83d66

Signed-off-by: cw-sakamoto <[email protected]>

kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 8, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

Merge branch 'main' into change_cert-manager_apiversion

1ef574c

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

k8s-ci-robot assigned kishorj Oct 4, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2021

kishorj approved these changes Oct 4, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021

k8s-ci-robot merged commit 1167abe into kubernetes-sigs:main Oct 5, 2021

cw-sakamoto deleted the change_cert-manager_apiversion branch October 5, 2021 02:37

z0rc mentioned this pull request Oct 13, 2021

[chart] apiVersion: cert-manager.io/v1alpha2 deprecated #2170

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cert-manager apiversion to v1 #2189

cert-manager apiversion to v1 #2189

Uh oh!

cw-sakamoto commented Aug 22, 2021

Uh oh!

k8s-ci-robot commented Aug 22, 2021

Uh oh!

codecov-commenter commented Aug 22, 2021 •

edited

Loading

Uh oh!

kishorj left a comment

Uh oh!

kishorj commented Aug 25, 2021

Uh oh!

cw-sakamoto commented Aug 27, 2021

Uh oh!

kishorj left a comment

Uh oh!

kishorj Sep 7, 2021

Uh oh!

cw-sakamoto Sep 8, 2021 •

edited

Loading

Uh oh!

kishorj commented Oct 4, 2021

Uh oh!

kishorj commented Oct 4, 2021

Uh oh!

k8s-ci-robot commented Oct 4, 2021

Uh oh!

Uh oh!

cert-manager apiversion to v1 #2189

cert-manager apiversion to v1 #2189

Uh oh!

Conversation

cw-sakamoto commented Aug 22, 2021

Issue

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Uh oh!

k8s-ci-robot commented Aug 22, 2021

Uh oh!

codecov-commenter commented Aug 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kishorj left a comment

Choose a reason for hiding this comment

Uh oh!

kishorj commented Aug 25, 2021

Uh oh!

cw-sakamoto commented Aug 27, 2021

Uh oh!

kishorj left a comment

Choose a reason for hiding this comment

Uh oh!

kishorj Sep 7, 2021

Choose a reason for hiding this comment

Uh oh!

cw-sakamoto Sep 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kishorj commented Oct 4, 2021

Uh oh!

kishorj commented Oct 4, 2021

Uh oh!

k8s-ci-robot commented Oct 4, 2021

Uh oh!

Uh oh!

codecov-commenter commented Aug 22, 2021 •

edited

Loading

cw-sakamoto Sep 8, 2021 •

edited

Loading